Enabling karma-coverage support #125
Conversation
|
Thank you for the work! I'm a little swamped at work but I'll review it soon. |
library/src/doo/karma.clj
Outdated
| [(:output-to compiler-opts) | ||
| {:pattern (->out-dir "/**") :included false} | ||
| {:pattern (->out-dir "/**/*.js") :included false} | ||
| {:pattern (->out-dir "/*.js") :included false}]) |
There was a problem hiding this comment.
This undoes the fix done in #153.
|
In master, there's now support for custom Karma configuration, so in principle you can configure coverage by hand. I think that support for |
|
@miikka thanks for looking into this, I've rewritten the feature on top of the latest master |
README.md
Outdated
|
|
||
| Add coverage seetings to your `project.clj` | ||
|
|
||
| :doo {:coverage {:packages [:my-app.module] |
There was a problem hiding this comment.
Small change suggested: to match the way e.g. cljsbuild :main is configured, it'd be nice to have packages be symbols instead of keywords. Your code already supports it, but it could be shown here: :packages [my-app.module].
library/src/doo/coverage.clj
Outdated
| "Adds preprocessors for sources from a given packages" | ||
| [->out-dir package] | ||
| (let [package-path (-> (name package) | ||
| (clojure.string/replace #"\." "/")) |
There was a problem hiding this comment.
Another replacement needed here is from - to _. E.g. if your package is my-app, the generated source will be in out-dir/my_app/ and not in out-dir/my-app/.
| (do | ||
| (utils/debug-log "Karma config:" (pr-str karma-opts)) | ||
| (utils/debug-log "Created karma conf file:" (.getAbsolutePath f))) | ||
| (.deleteOnExit f)) |
There was a problem hiding this comment.
Heh, thanks, not deleting the config makes debugging much easier.
library/src/doo/karma.clj
Outdated
| @@ -93,7 +94,9 @@ | |||
| "client" {"args" ["doo.runner.run_BANG_"]} | |||
| "singleRun" true | |||
| "plugins" (into ["karma-cljs-test"] launcher-plugins)} | |||
| (get-in opts [:karma :config])))) | |||
| (get-in opts [:karma :config]) | |||
| (coverage/settings ->out-dir opts) | |||
There was a problem hiding this comment.
Could you swap the order of these two lines? It'd be best to have user's [:karma :config] last so that they can override anything they want, if needed.
example/project.clj
Outdated
| @@ -1,4 +1,4 @@ | |||
| (defproject lein-doo-example "0.1.10-SNAPSHOT" | |||
| (defproject lein-doo-example "0.2.1-SNAPSHOT" | |||
There was a problem hiding this comment.
I'd prefer it if feature pull requests didn't change the version numbers – I'd like to do it separately when I do a new release and the next version is not going to be 0.2.1 anyway (it's either 0.1.10 or 0.2.0). Could you remove these changes from your commit?
alun
force-pushed
the
master
branch
2 times, most recently
from
24ae942
to
461d026
Compare
|
@miikka thanks, all of your remarks are fixed |
This PR contains modifications which are adding karma-coverage support for karma runner.
In the end it's possible to measure the coverage, add minimum expectations and generate coverage report on the compiled .cljs files
Also karma-config is changed to have keywords as keys while working with it in clojure.