Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dragster.js #6

Closed
wants to merge 1 commit into from
Closed

Update dragster.js #6

wants to merge 1 commit into from

Conversation

leefernandes
Copy link

sorry I don't use Coffeescript, but this is how I'm using dragster to support drops.

sorry I don't use Coffeescript, but this is how I'm using dragster to support drops.
@bensmithett
Copy link
Owner

Cheers! I'm away on holidays at the moment, will check it out when I get
back in a couple of weeks :)

On Friday, 27 June 2014, 17NuF432QCV2vF4fdqYPYMdCuK9jHVDSNG <
[email protected]> wrote:

sorry I don't use Coffeescript, but this is how I'm using dragster to

support drops.

You can merge this Pull Request by running

git pull https://github.com/ItsLeeOwen/dragster gh-pages

Or view, comment on, or merge it at:

#6
Commit Summary

  • Update dragster.js

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#6.

@bensmithett
Copy link
Owner

Finally got a look at this - yeah this is how I'm handling drops too, except I just add the dragover & drop listeners directly to the element.

I've just merged #7, which exposes a reset function you can call upon drop that does the extra bits in your drop callback.

I want to do as little messing with the original events as possible, so I think for now I'll still leave cancelling the dragover event for implementation rather than including it in the library.

@leefernandes
Copy link
Author

Nice work Ben! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants