Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract shared methods/scopes into a BaseExecution to share between Execution and Job models #894

Merged
merged 1 commit into from
Apr 2, 2023
Merged

Extract shared methods/scopes into a BaseExecution to share between Execution and Job models #894

merged 1 commit into from
Apr 2, 2023

Conversation

bensheldon
Copy link
Owner

Connects to #886 (comment)

@bensheldon bensheldon temporarily deployed to goodjob-json-executions-yxt4kl March 16, 2023 15:05 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-json-executions-yxt4kl March 16, 2023 19:56 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-json-executions-yxt4kl March 16, 2023 20:04 Inactive
@ollym
Copy link

ollym commented Mar 17, 2023 •
edited
Loading

@bensheldon don't forget to replace GoodJob::BaseFilter#job_classes which makes reference to serialized_params->>'job_class' which instead should fetch the column from here ^

@bensheldon
Extract shared methods/scopes into a BaseExecution to share between E…
5db9a2d 
…xecution and Job models; remove deprecated ActiveJobJob model
@bensheldon
Copy link
Owner Author

@ollym thank you for catching that 🙏🏻

@bensheldon bensheldon merged commit 685d80b into main Apr 2, 2023
@bensheldon bensheldon deleted the json_executions branch April 2, 2023 05:22
@bensheldon bensheldon added the refactor Code changes that do not introduce new features label Apr 2, 2023
@ollym ollym mentioned this pull request Apr 2, 2023
Open
bensheldon added a commit that referenced this pull request Apr 11, 2023
@dependabot @eric-christian
@eric-wtfoxtrot @bensheldon @ain2108 @patriciomacadden @ckdake
Bump erb_lint from 0.3.1 to 0.4.0 (#906)
3794dbf 
* Bump rails from 7.0.4.2 to 7.0.4.3 (#904)

Bumps [rails](https://github.com/rails/rails) from 7.0.4.2 to 7.0.4.3.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v7.0.4.2...v7.0.4.3)

---
updated-dependencies:
- dependency-name: rails
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump selenium-webdriver from 4.8.1 to 4.8.6 (#905)

Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.8.1 to 4.8.6.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES)
- [Commits](https://github.com/SeleniumHQ/selenium/commits)

---
updated-dependencies:
- dependency-name: selenium-webdriver
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump benchmark-ips from 2.11.0 to 2.12.0 (#907)

Bumps [benchmark-ips](https://github.com/evanphx/benchmark-ips) from 2.11.0 to 2.12.0.
- [Release notes](https://github.com/evanphx/benchmark-ips/releases)
- [Changelog](https://github.com/evanphx/benchmark-ips/blob/master/History.md)
- [Commits](evanphx/benchmark-ips@v2.11.0...v2.12.0)

---
updated-dependencies:
- dependency-name: benchmark-ips
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: locales for de (#903)

Co-authored-by: Eric <[email protected]>

* Add translate_hash to handle missing translation keys that return hashes; only show translatable/available locales in dropdown (#891)

* Update README.md (#902)

* Add `translate_hash` to handle missing translation keys that return hashes; only show translatable/available locales in dropdown

---------

Co-authored-by: Anton Nefedenkov <[email protected]>

* Extract more Dashboard strings into localization strings (#899)

* improve translations

* more translations

* fix translation (fixes test)

* added missing i18n strings

* Translate all languages

* Update DE translation

* Fix missing key

* empty commit

* Fix missing UA string

---------

Co-authored-by: Ben Sheldon [he/him] <[email protected]>

* Extract shared methods/scopes into a BaseExecution to share between Execution and Job models; remove deprecated ActiveJobJob model (#894)

* Release good_job v3.15.0

* Switches from Chrome to Chromium to support Apple M1/Arm CPUs (#910)

* Remove mention of `Batch.add` method that doesn't exist

* Fix lint: missing fr and nl translations; readme whitespace (#914)

* Fix missing fr and nl translations

* Fix whitespace in Readme

* Use `GoodJob.capsule` in CLI instead of creating a new Capsule (#916)

* Set `successfully_enqueued?` when using `perform_all_later` (#917)

* In tests, directly use `connection.truncate_tables` instead of  `ActiveRecord::Tasks::DatabaseTasks.truncate_all` (#918)

* Bump erb_lint from 0.3.1 to 0.4.0

Bumps [erb_lint](https://github.com/Shopify/erb-lint) from 0.3.1 to 0.4.0.
- [Release notes](https://github.com/Shopify/erb-lint/releases)
- [Commits](Shopify/erb_lint@v0.3.1...v0.4.0)

---
updated-dependencies:
- dependency-name: erb_lint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: eric-christian <[email protected]>
Co-authored-by: Eric <[email protected]>
Co-authored-by: Ben Sheldon [he/him] <[email protected]>
Co-authored-by: Anton Nefedenkov <[email protected]>
Co-authored-by: Patricio Mac Adden <[email protected]>
Co-authored-by: Chris Kelly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor Code changes that do not introduce new features
Projects
GoodJob Backlog v2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bensheldon @ollym