Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoodJob.cleanup_preserved_jobs: add :include_discarded option #1550

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GoodJob.cleanup_preserved_jobs: add :include_discarded option #1550

wants to merge 1 commit into from

Commits on Nov 26, 2024

  1. GoodJob.cleanup_preserved_jobs: add :include_discarded option 

    This change allows the caller of GoodJob.cleanup_preserved_jobs to
specify the :include_discarded option, rather than always relying on the
value that is set in the configuration.

This would enable us to e.g. set
config.cleanup_preserved_jobs_before_seconds_ago to a very low value
(e.g. 10 seconds), but also set config.cleanup_discarded_jobs = false so
that we can retain discarded jobs for longer in case we want to inspect
them or manually retry then.

We would then set up a separate maintenance job to call
GoodJob.cleanup_preserved_jobs(older_than: some_longer_period,
include_discarded: true).
    @jonleighton
    jonleighton committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    ce488e1 View commit details
    Browse the repository at this point in the history