Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ContentSite misaligning PART_EditableTextBox when editing (ComboBox) #70

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

LaughingLeader
Copy link
Contributor

@LaughingLeader LaughingLeader commented Feb 20, 2020

Describe the bug
When a ComboBox flips between IsEditable true/false, the editable textbox (PART_EditableTextBox) gets misaligned due to the width of the hidden ContentSite.

Collapsing ContentSite instead of hiding it fixes this issue.

To Reproduce
Steps to reproduce the behavior:

  1. Initialize IsEditable to "False" on a ComboBox using the default AdonisUI style.
  2. While the app is running, set IsEditable to true while the ComboBox has a valid item name.
  3. The editable textbox is pushed to the right from the ContentSite's width.

Expected behavior
PART_EditableTextBox should be in the same spot that ContentSite is, so the text is aligned when switching between IsEditable true/false.

Screenshots
Example when using Visibility.Hidden:

When using Hidden for Visibility

Example when using Visibility.Collapsed (expected/desired behavior):

When using Collapsed for Visibility

@LaughingLeader LaughingLeader changed the title Fix for ContentSite misaligning PART_EditableTextBox when editing Fix for ContentSite misaligning PART_EditableTextBox when editing (ComboBox) Feb 20, 2020
@benruehl
Copy link
Owner

Seems to work fine, thanks!

@benruehl benruehl added the bug Something isn't working label Feb 25, 2020
@benruehl benruehl added this to the Release 1.14 milestone Feb 25, 2020
@benruehl benruehl merged commit 13eae1d into benruehl:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants