Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncaught exeption when app is started from different directory #64

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

benruehl
Copy link
Owner

Assembly.GetEntryAssembly()?.ManifestModule.Name returns the executable's name only (e.g AdonisUI.Demo.exe) whereas Assembly.GetEntryAssembly()?.ManifestModule.FullyQualifiedName returns the full path (e.g C:\AdonisUI.Demo.exe).

This is important for cases where the application is started via CLI from a different directory. The full path is required here in order to resolve the assembly the icon is extracted from.

Fixes #63

@benruehl benruehl added the bug Something isn't working label Feb 11, 2020
@benruehl benruehl added this to the Release 1.14 milestone Feb 11, 2020
@benruehl benruehl self-assigned this Feb 11, 2020
@benruehl benruehl merged commit 4b230e7 into master Feb 13, 2020
@benruehl benruehl deleted the hotfix/app-icon branch February 13, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adonis.Window Crashes on startup if not launched from the base directory
1 participant