.NET 5 fix singlefile apps crashing on fetching app icon #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159
When a application using AdonisUI uses .net5 was compiled as
<SelfContained>true</SelfContained>
and<PublishSingleFile>true</PublishSingleFile>
then
Assembly.GetEntryAssembly()?.ManifestModule.FullyQualifiedName
won't return a valid filename.I replaced that call with
and also added a check for the returned path actually pointing to a valid file, just in case things change again in the future.