Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in xaml designer caused by space extension #105

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

benruehl
Copy link
Owner

This aims at solving design time errors caused by the SpaceExtension. It is not really proven that this actually helps because the errors appear and disappear kind of randomly. Both changes seem to affect the designer in some kind though. All errors appear only when the xaml designer is enabled.

  • Add special treatment of the design mode to the space markup extension
  • Specify multiple parameters for space extension usages in style setters

Fixes #89

benruehl added 2 commits June 17, 2020 23:38
Add special treatment of the design mode to the space markup extension.
This aims at solving design time errors. It is not really prooven that this
actually helps because the errors appear and disappear kind of randomly.
Specify multiple parameters for space extension in style setters.
This aims at solving design time errors. It is not really prooven that this
actually helps because the errors appear and disappear kind of randomly.
It seems to have an impact on the designer though.
@benruehl benruehl added the bug Something isn't working label Jun 17, 2020
@benruehl benruehl added this to the 1.16 milestone Jun 17, 2020
@benruehl benruehl self-assigned this Jun 17, 2020
@benruehl benruehl merged commit a35fd87 into master Jun 17, 2020
@benruehl benruehl deleted the feature/fix-space-extension-designer-error branch June 17, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adonisUI:Space throw error
1 participant