Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style for bottom right corner in ScrollView is missing #23

Closed
Thimilius opened this issue May 1, 2019 · 4 comments
Closed

Style for bottom right corner in ScrollView is missing #23

Thimilius opened this issue May 1, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@Thimilius
Copy link

I encounterd a missing styling in the ScrollView that is inside a TextBox.

The corner rectangle in the bottom right that fills the space for both the vertical and horizontal scrollbar is tinted white in dark mode:
ScrollView_Bug

There sort of is a workaround as it is possible to override this style with the following code:

<TextBox>
    <TextBox.Resources>
        <SolidColorBrush x:Key="{x:Static SystemColors.ControlBrushKey}" Color="{DynamicResource {x:Static adonisUi:Colors.Layer2BackgroundColor}}"/>
    </TextBox.Resources>
</TextBox>

Resulting into the following:
ScrollView_Workaround

But unfortunatley this overridden color does not match the background gradient of the TextBox that is present for the first 100 pixels or so.
(The color difference might be hard to notice in the images)

@Thimilius Thimilius added the bug Something isn't working label May 1, 2019
@benruehl
Copy link
Owner

benruehl commented May 3, 2019

Thank you for reporting this!
I will have a look at it as soon as I can.

benruehl added a commit that referenced this issue May 5, 2019
@benruehl benruehl closed this as completed May 5, 2019
@Atulin
Copy link

Atulin commented Jun 21, 2019

Has this been merged into master? I'm having the issue as well:
image
Using AdonisUI 1.10.0

@benruehl
Copy link
Owner

It is merged and should be fixed in the latest version on NuGet as well (v1.11.0-preview).

PS:
A stable version is following in a few days I hope. I released it as a preview because the NuGet packaging changed in this release because of .NET Core 3.0 and I wanted to be careful to not break anything. But as everything seems to work fine for everyone and my personal tests passed as well, I will probably just make the current release a stable one without changing anything. So the preview can be used relatively safely.

@Atulin
Copy link

Atulin commented Jun 21, 2019

Glad to hear, I'm not in a hurry with the release so I'll wait for it to go to master. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants