fix: enhance error message when image is not there (podman-desktop#3587)

fixes podman-desktop#3496
Signed-off-by: Florent Benoit <[email protected]>

packages/main/src/plugin/container-registry.spec.ts

@@ -30,6 +30,7 @@ import type * as podmanDesktopAPI from '@podman-desktop/api';
 import nock from 'nock';
 import { LibpodDockerode } from './dockerode/libpod-dockerode.js';
 import moment from 'moment';
+import type { ProviderContainerConnectionInfo } from './api/provider-info.js';
 
 /* eslint-disable @typescript-eslint/no-empty-function */
 /* eslint-disable @typescript-eslint/no-explicit-any */
@@ -118,6 +119,10 @@ class TestContainerProviderRegistry extends ContainerProviderRegistry {
   addContainerProvider(name: string, provider: podmanDesktopAPI.ContainerProviderConnection): void {
     this.containerProviders.set(name, provider);
   }
+
+  getMatchingEngineFromConnection(providerContainerConnectionInfo: ProviderContainerConnectionInfo): Dockerode {
+    return this.getMatchingEngineFromConnection(providerContainerConnectionInfo);
+  }
 }
 
 let containerRegistry: TestContainerProviderRegistry;
@@ -734,3 +739,32 @@ describe('listContainers', () => {
     expect(container.State).toBe('running');
   });
 });
+
+test('pull unknown image ', async () => {
+  const getMatchingEngineFromConnectionSpy = vi.spyOn(containerRegistry, 'getMatchingEngineFromConnection');
+
+  const pullMock = vi.fn();
+
+  const fakeDockerode = {
+    pull: pullMock,
+    modem: {
+      followProgress: vi.fn(),
+    },
+  } as unknown as Dockerode;
+
+  getMatchingEngineFromConnectionSpy.mockReturnValue(fakeDockerode);
+
+  const containerConnectionInfo = {} as ProviderContainerConnectionInfo;
+
+  // add statusCode on the error
+  const error = new Error('access denied');
+  (error as any).statusCode = 403;
+
+  pullMock.mockRejectedValue(error);
+
+  const callback = vi.fn();
+  // check that we have a nice error message
+  await expect(containerRegistry.pullImage(containerConnectionInfo, 'unknown-image', callback)).rejects.toThrow(
+    'access to image "unknown-image" is denied (403 error). Can also be that image does not exist',
+  );
+});

packages/main/src/plugin/container-registry.ts

@@ -862,6 +862,11 @@ export class ContainerProviderRegistry {
 
       return promise;
     } catch (error) {
+      // Provides a better error message for 403 errors
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      if (error instanceof Error && (error as any)?.statusCode === 403) {
+        error.message = `access to image "${imageName}" is denied (403 error). Can also be that image does not exist.`;
+      }
       telemetryOptions = { error: error };
       throw error;
     } finally {

packages/renderer/src/lib/image/PullImage.svelte

@@ -86,7 +86,7 @@ async function pullImage() {
     pullFinished = true;
   } catch (error) {
     const errorMessage = error.message ? error.message : error;
-    pullError = 'Could not connect to ' + selectedProviderConnection.name + ': ' + errorMessage;
+    pullError = `Error while pulling image from ${selectedProviderConnection.name}: ${errorMessage}`;
     pullInProgress = false;
   }
 }