fix(hackney_url): parses query string before userinfo #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #751 |
|
@benoitc Please take a look. It's the smallest fix I could come up with. It doesn't break the contract thus shouldn't break the existing code. No need to get rid of parsing userinfo. Thank you in advance 🙏 |
|
this is going to be merged? |
tank-bohr
force-pushed
the
cve-2025-1211
branch
from
25ca247 to
e9fa5cd
Compare
|
@tank-bohr thank you. I'm looking at why tests are failing but it should be good. |
|
|
thank you. I have one another change to merge and will make a release |
This was referenced Feb 18, 2025
|
@benoitc Is there an ETA for the release? |
|
@benoitc thank you for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #752 cve-2025-1211