aiohttp worker

[fafhrd91]

@benoitc aiohttp has unittests for worker, i'm not sure you want me to move as well.

[asvetlov]

The patch is LGTM.
I'm +0 for adding tests also.
They are already present, so moving tests from aiohttp into gunicorn is quick.
But I cannot find any tests for other workers: tornado, gevent, eventlet etc.

[asvetlov]

Also I have a question about documentation. Is there enough to mention gaiohttp worker in design.rst and settings.rst?
Also I don't grok structure of news files. Should the change to be mentioned in both news.rst and 2014-news.rst?

[benoitc]

@fafhrd91 @asvetlov we really need to add tests for worker but it can be done later imo( @davisp @tilgovi thoughts?) .

I just tested the worker with the test example and got the following error:

2014-06-07 14:51:04 [4579] [ERROR] Error handling request
Traceback (most recent call last):
  File "/home/benoitc/work/gunicorn/env_py3/lib/python3.4/site-packages/aiohttp/server.py", line 189, in start
    yield from handler
  File "/home/benoitc/work/gunicorn/env_py3/lib/python3.4/site-packages/aiohttp/wsgi.py", line 166, in handle_request
    yield from resp.write(item)
  File "/home/benoitc/work/gunicorn/env_py3/lib/python3.4/site-packages/aiohttp/protocol.py", line 664, in write
    self.send_headers()
  File "/home/benoitc/work/gunicorn/env_py3/lib/python3.4/site-packages/aiohttp/protocol.py", line 633, in send_headers
    hdrs = hdrs.encode('ascii') + b'\r\n'

To fix it i had to comment the following line:

--- test.py 2014-06-02 07:37:42.116918158 +0200
+++ test_asyncio.py 2014-06-07 14:48:20.010819384 +0200
@@ -25,7 +25,7 @@
         ('Content-type','text/plain'),
         ('Content-Length', str(len(data))),
         ('X-Gunicorn-Version', __version__),
-        ("Test", "test тест"),
+        #("Test", "test тест"),
     ]
     start_response(status, response_headers)
     return iter([data])

In the gunicorn.http.wsgi module we are fixing it with value = str(value).strip() and once we are sending the headers string is converted using the function util.to_bytestring. Maybe that could also be fixed in aiohttp?

The rest is OK for me.

[benoitc]

@asvetlov settings.rst is build from the config.py file. So any doc should be added in the module source code. The worker should be advised in design.rst indeed. (It also should be done for the threaded worker).

there is one changelog / year and 1 "current" changelog indeed... I didn't find the time yet to make it automatic :)

[benoitc]

i opened an issue in the aiohttp project with a possible patch. It's expected to have headers as utf8.

[asvetlov]

@benoitc as you can see we have fixed utf8 headers problem on master but we need for other important to aiohttp issues before making new release.
If you can wait for us or if you can publish new gunicorn release tomorrow with current state -- that's fine.
As an option we can cherry-pick the utf-8 patch into 0.7.4 aiohttp bugfix release quickly -- that will not stop you from publishing new gunicorn release.

For documentation changes would do you like to do it yourself?
I'll be unavailable for tomorrow (sorry, I've invited to BBQ party).

If you like the plan -- let me know.

[benoitc]

@asvetlov Thanks! cherry-picking would be the best option if you can't do the other changes next week. I am travelling tomorrow. I will decide on Monday what to do. Will also test the final patch.

@tilgovi @davisp let me know what you think about it anyway :)

[asvetlov]

As I see the point of decision has moved to Monday.
Nikolay @fafhrd91 want to make 0.8 aiohttp release shortly.
Sure, he will do it.
But if aiohttp will still not ready to make new release at point-of-decision we can switch to bugfix release.

Anyway, @benoitc please take care on gunicorn documentation upgrade.

[benoitc]

@fafhrd91 @asvetlov cool, let me know for the release. I planned the next gunicorn on friday (with everything done on thursday).

I have created #779 to make sure to not forget about the doc.

[fafhrd91]

i've just released 0.8.0 version.

[benoitc]

+1 for the merge

[asvetlov]

Tests added in e1d97f1