Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Improvements #2927

Merged
merged 2 commits into from
Jan 26, 2023
Merged

CI Improvements #2927

merged 2 commits into from
Jan 26, 2023

Conversation

samypr100
Copy link
Contributor

Summary of changes

  1. Updated the CI as part of Fix CI: replace Travis CI. #2641 to use full matrix for Linux/OSX as well as non-eol python versions
  2. Cherry picked c04a30f to get tests working
  3. Fixed some tox issues preventing tox from working due to v4 changes discussed here
  4. Adjusted linting to use pylint version where it used to pass (back in travis CI days), if we want to use latest and correct the linting issues as they come we can revert the pylint version lock

I realized a bit too late that you were already working on #2920, so I apologize if you think this seems duplicative.

🔗 to workflows on my fork for this branch

Failing CI Issues Left

  1. pycodestyle doesn't seem to pass in any version I tested, so maybe that should be a separate PR?

benoitc and others added 2 commits January 22, 2023 12:47
Working Matrix for both lint/tox
Fixing tox v4 issues
Adjust pylint to working version
@benoitc
Copy link
Owner

benoitc commented Jan 22, 2023

yes let's fix pycodestyle errors apart. thanks a lot for your PR!

@benoitc benoitc merged commit bba59ae into benoitc:master Jan 26, 2023
@johnthagen
Copy link
Contributor

@benoitc In order to keep the CI green, you could set all of the GitHub Actions checks as required in order to allow a PR to be merged:

As the administrator of the repo you can always still override them, but this can help from accidentally merging a PR where one of the checks fail.

@samypr100
Copy link
Contributor Author

@johnthagen Good suggestion, I've attached some Screenshots of how it would look like if its desired to go that route

Branch Protection Rules

All Rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants