http/message: Split request line as bytes to avoid splitting on 0x0A. Fixes #1577 #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilgovi
reviewed
Aug 27, 2017
| yield bytes(d.encode("latin1")) | ||
| for d in self.data: | ||
| if six.PY3: | ||
| yield bytes([d]) |
There was a problem hiding this comment.
I don't think the cast is necessary anymore, since we open the file in binary mode.
There was a problem hiding this comment.
I'm not sure what was the intention there, but it's reading the data byte-by-byte and yielding byte-by-byte.
In py2, iterating the data str will yield individual bytes as str
In py3, iterating the data bytes will yield individual bytes as int, which then need to be returned as new bytes using bytes([d])
Previous code was just plain wrong under py2 as str(self.data.decode("latin1")) will try to re-encode an unicode string in ascii
There was a problem hiding this comment.
Thanks for the explanation.
|
Looks good. Thank you! |
|
@berkerpeksag, @benoitc do you see any problem with this? |
mjjbell
pushed a commit
to mjjbell/gunicorn
that referenced
this pull request
Mar 16, 2018
http/message: Split request line as bytes to avoid splitting on 0x0A. Fixes benoitc#1577
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.