Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that a parameterised Slack command matches the corresponding run_args_template #707

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

alarthast
Copy link
Contributor

Fixes #704 .

  • Add a validation in build_config that checks that a given parameterised Slack command has parameters that matches the run_args_template for the corresponding job
  • Since build_config is run on all our jobs whenever a unit test file imports job_configs, a run of all tests (locally or in CI) will trigger the validation and catch any errors in the raw_config

Copy link
Contributor

@rebkwok rebkwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for doing this :)

@alarthast alarthast merged commit b50be1f into main Feb 7, 2025
5 checks passed
@alarthast alarthast deleted the aw/command-verification branch February 7, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test that our command configs match the expected parameters of the corresponding jobs
2 participants