-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CssRewriteUrlTransformFixed strips out quotes in url #8
Comments
Hi @mrbelk, If you disable minification, by setting in your web.config, do the surrounding quotes remain? Just wondering if it's the minifier which could be getting rid of quotes thinking they aren't required, because usually they aren't. |
Well, it doesn’t do it when I am debugging; let me try setting that property on the BundleTable class in global.asax.cs on my “release” test site. Thanks, |
well, that's awesome. When I set BundleTable.EnableOptimizations = false; in global.asax.cs, everything works right. clearly this is non-optimal, though. |
It's okay, I just need to adjust the regex like you mentioned. Working on a fix now. |
awesome. thanks. will you update the nuget package fairly quickly? |
…ike data:, keep their surrounding quotations chars in case they are needed, e.g. non-base64 encoded svg. #8
Give it a quick second but it's up now, v2.0.2: Cheers for logging the bug! Another reason to use my package as that regex was straight out of the original library. |
awesome. thanks for such a quick turnaround on this. |
No worries. You caught me just before I went to bed. 12:15am here now in Aus haha. All the best. |
perfect timing, then. nighty night. |
I had some issues with embedded graphics in a background image. Here is the CSS:
As you know, the ASP.NET bundling system wants to make the "data" part a relative URL and the image breaks. I installed your Nuget and, while it corrects that behavior, it also seems to strip the containing quotes inside the "url" value and the image can't be rendered.
According to Chrome's inspector, the CSS looks like this:
I think it must be something in your regex match/replace.
Thanks,
Matthew
The text was updated successfully, but these errors were encountered: