pex_binary: Pass interpreter attribute as --python-shebang #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pex_binary interpreter attribute is documented as "Path to the python interpreter the pex should to use in its shebang line." However, it was not being passed when building the PEX, so it did not take effect. It is getting passed as PEX_PYTHON, which changes the interpreter used for *that invocation* of a given pex. This may have been a recent change: pex-tool/pex#53 interpreter_test.py: Add a test that reads the files and verifies that the interpreter is set correctly.
|
Any reason why this isn't merged in? Just incorporated it a local copy today and works perfectly. |
|
Hrmmm. At some point we probably ought to transition to py_runtime for specifying python interpreters, but this looks like a good thing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pex_binary interpreter attribute is documented as "Path to the
python interpreter the pex should to use in its shebang line."
However, it was not being passed when building the PEX, so it did not
take effect.
It is getting passed as PEX_PYTHON, which changes the interpreter used
for that invocation of a given pex. This may have been a recent
change: pex-tool/pex#53
interpreter_test.py: Add a test that reads the files and verifies
that the interpreter is set correctly.