feat(es2015): add es2015 implementation to support rollup #10
Conversation
The build now comes from the es2015 files under the `es/` directory. closes #9
| @@ -0,0 +1,17 @@ | |||
| export default function symbolObservablePonyfill(root) { | |||
| let result; | |||
| let Symbol = root.Symbol; | |||
There was a problem hiding this comment.
- let Symbol = root.Symbol;
+ const Symbol = root.Symbol;
|
After looking at this, I am wondering if we haven't misidentified the problem in #9. It doesn't seem right that Rollup would require you to rewrite existing CommonJS modules as ES2015 modules. This certainly isn't required when using |
You can make it work by adding a special CommonJS plugin but vanilla Rollup will break. In Redux, we used to support vanilla Rollup specifically. Depending on this library breaks that support for us. |
|
This plugin?: https://github.com/rollup/rollup-plugin-commonjs |
| @@ -12,7 +12,8 @@ | |||
| "node": ">=0.10.0" | |||
| }, | |||
| "scripts": { | |||
| "test": "mocha" | |||
| "build": "babel es --out-dir lib", | |||
There was a problem hiding this comment.
Add build to the prepublish script as well:
"prepublish": "npm run build"
|
Yes, that one. If we ask people to use it, we might as well remove ES build from Redux completely because what's the point: they have to add it anyway. :-/ |
| }, | ||
| "files": [ | ||
| "index.js", | ||
| "ponyfill.js", | ||
| "index.d.ts" | ||
| "index.d.ts", | ||
| "es/index.js", |
There was a problem hiding this comment.
I think you’d need to add "jsnext:main": "es/index.js" for Rollup to discover the ES build. The es folder name is just a convention I use.
The build now comes from the es2015 files under the
es/directory.closes #9
cc/ @gaearon for review.