-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release-publishing workflow using GoReleaser #1
base: main
Are you sure you want to change the base?
Conversation
Personally, the way I create new tags is:
|
@@ -31,7 +31,7 @@ import ( | |||
"github.com/aws/smithy-go" | |||
) | |||
|
|||
var Version string = "2.6" | |||
var version string = "(unknown)" // this is set by goreleaser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not export the version, if this is used as a module in a bigger program?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this also loses go install
'd versioning. I've recently been using https://github.com/carlmjohnson/versioninfo/ which works for both goreleaser and go install
, and should also work when imported as a library
homepage: https://github.com/benkehoe/aws-whoami-golang | ||
maintainer: Ben Kehoe | ||
description: A tool to show what AWS account and identity you're using. | ||
formats: [ deb ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you ever tried to make an RPM easily available for installation on Amazon Linux? I'm not clear if that would have to involve getting it in a particular yum repo or what
Here's a PR that will use GoReleaser for publishing new releases. A few things to note:
GORELEASER_HOMEBREW_TAP_TOKEN
in the Actions secrets for this repo.Version
var toversion
. This variable will be populated at compile-time by GoReleaser with the name of the tag. Cmd+Fldflags
on this page for more info.