feat: support checked syndication targets #16
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to add support for the
checked
property that can be returned in a query for an endpoint’s syndication targets.I thought it might be as easy as adding the following to the individual checkboxes:
m('label', [ s.name, m('input', { type: 'checkbox', + checked: s.checked, onchange: e => updateSyndicateTo(e, s) }) ])
While that worked, it prevented the checkboxes from being toggled. Also,
updateSyndicateTo
updates themp-syndicate-to
property when a checkbox is interacted with; with pre-checked checkboxes, a user might not interact with these form elements at all.So instead I’m now calculating which syndication checkboxes have been checked on form submit.
However, perhaps given the way Mithril.js works – maybe updating and reseting the DOM on every event, I’m not sure – interacting with any other form element will reset the checkboxes back to their original state.
Hopefully there is enough here to begin reviewing this feature, and just a small change is needed to make this PR work as intended.