-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resize scale enum variant #61
Conversation
11cda74
to
79e60c6
Compare
79e60c6
to
caab271
Compare
caab271
to
9662f43
Compare
First of all, thank you! I really had You can run an approximation of the CI with This is suprising to me, I would expect the image to scale down as well instead of being cropped. I also suspect it's not really getting cropped, just overdrawn, which might cause subtle problems down the line. Could you look into this? I think for |
By the way do we really need to have text under the images in the demo? |
It scales down, but sometimes it doesn't take up the full space if you play around with window size / layout.
It helps a lot to eyeball glitches in different terminals. Since we're writing control sequences into some buffer, there can and have been conflicts with surrounding control sequences related to style. |
@TadoTheMiner okay, yea there seems to be some bug, although I can't exactly reproduce your screenshot. I will merge this branch manually and push to master. I just disabled merge commits while you were working on this, sorry. I'll also add a note to the readme about this. |
Rebased and merged in |
This pr adds the
Resize::Scale
option in #59, and adds it to the demo instead of the placeholder. I've noticed that in the code three timesstatic
was used whenconst
could be, so I replaced it. As I changed the demo to include theResize::Scale
option, the gif must be re-generated