GOML JB Week5 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdfa
need functional TestFX for more testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4614
Tried to find the class causing this bug. Unit tests showed that this issue could be related to JavaFX in the DuplicateResolverDialog class because all non-JavaFX tests were successful. Testing will continue once my IDE is setup for JavaFX unit testing because most of its functionality is inside a private method only accessible through a constructor that requires JavaFX dependent classes. It could also be in the ImportInspectionDialog class, but it was the same situation where all the methods of interest needed JavaFX tests. Testing coverage: 2 Classes, 4 Methods, and 12 Lines.