Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizations of Javascript and little bug corrections #30

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

piwel
Copy link
Contributor

@piwel piwel commented Aug 3, 2013

Hi,

First of all thanks a lot for sharing this beautiful plugin with everyone, it's really useful.

I would like to contribute to your work by adding some enhancement to this plugin... It's a big change, but I tried to commit separately all the things I do in order you to be able simply to pick what you want if you don't want all of it.

Theses are the changes of this pull request :

  • Suppress CTRL+M end lines in the CSS and tries to fix themes using box-shadow on images
    For example, with Twenty Twelve theme, all parts of the map is surrounded by box-shadows.
  • Replaces header and footer scripts by HTML5 data description and jQuery selectors to rebuild the maps in a generic way
    This enhancement is offered to solve these issues :
  • Async load of Google Maps API Script
  • Use of Static maps API to offer the admin user to :
  • Restore the overview option on GmapsV3

(please apologize my English...)

@piwel
Copy link
Contributor Author

piwel commented Sep 19, 2013

Take care, you have to add the following line in the 2 functions wp_footer in order it not to break the feed :

if(is_feed()) return;

@benhuson
Copy link
Owner

@piwel This is all great and something I would like to implement - I had already started thinking of the best approach.

I think what you've done is great, but it would be good to do it in a way so that maps could automtaically handle multiple markers too.

It might be that the map settings should be stored as attributes on the map div, and there should be a list or multiple divs instead the map div to which marker data could be added.

@piwel
Copy link
Contributor Author

piwel commented Mar 5, 2014

Hi Ben :)

Do you have news about it ?

@benhuson
Copy link
Owner

benhuson commented Mar 5, 2014

I've not had chance to fully review this yet.
I try to take a bit of look through now.
Sorry

@piwel
Copy link
Contributor Author

piwel commented Mar 5, 2014

Thanks :) There's no rush, but I stopped updating the extension since then and that would be so great if it was integrated :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants