-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizations of Javascript and little bug corrections #30
base: master
Are you sure you want to change the base?
Conversation
… images (like Twenty Twelve)
…ry selectors to rebuild the maps in a generic way
Take care, you have to add the following line in the 2 functions wp_footer in order it not to break the feed :
|
@piwel This is all great and something I would like to implement - I had already started thinking of the best approach. I think what you've done is great, but it would be good to do it in a way so that maps could automtaically handle multiple markers too. It might be that the map settings should be stored as attributes on the map div, and there should be a list or multiple divs instead the map div to which marker data could be added. |
Hi Ben :) Do you have news about it ? |
I've not had chance to fully review this yet. |
Thanks :) There's no rush, but I stopped updating the extension since then and that would be so great if it was integrated :-) |
Hi,
First of all thanks a lot for sharing this beautiful plugin with everyone, it's really useful.
I would like to contribute to your work by adding some enhancement to this plugin... It's a big change, but I tried to commit separately all the things I do in order you to be able simply to pick what you want if you don't want all of it.
Theses are the changes of this pull request :
For example, with Twenty Twelve theme, all parts of the map is surrounded by box-shadows.
This enhancement is offered to solve these issues :
<script>
tag anymore, that permits plugins like wp-minify to minify all the script(please apologize my English...)