Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify times written in the style of 1:23a #18

Open
zackshapiro opened this issue Dec 15, 2013 · 6 comments
Open

Identify times written in the style of 1:23a #18

zackshapiro opened this issue Dec 15, 2013 · 6 comments

Comments

@zackshapiro
Copy link

Times written with no space between the last number and am, pm, a, or p don't get ID'd

Verified with the demo @ http://byteaspect.com/knwlDemo/

@benhmoore
Copy link
Owner

Will look into it, thanks for the heads up!

@zackshapiro
Copy link
Author

Happy to work on it in the future, just wanted to make a note. Love the
library!

On Sun, Dec 15, 2013 at 2:36 PM, LoadFive [email protected] wrote:

Reopened #18 #18.


Reply to this email directly or view it on GitHubhttps://github.com//issues/18
.

@benhmoore
Copy link
Owner

@zackshapiro Thanks for the love, Knwl.js now detects dates like "12:32pm" as well as "3am".

@zackshapiro
Copy link
Author

Rad! Thank you!

Maybe in the future you could make it support 12:32p and 3a as well? That
seems to come up a bunch online, though less frequently

On Mon, Dec 23, 2013 at 10:06 PM, LoadFive [email protected] wrote:

@zackshapiro https://github.com/zackshapiro Thanks for the love,
Knwl.js now detects dates like "12:32pm" as well as "3am".


Reply to this email directly or view it on GitHubhttps://github.com//issues/18#issuecomment-31160010
.

@g1derekl
Copy link

g1derekl commented May 18, 2016

@loadfive I know this was closed a while ago, but this still doesn't seem to work. Parsing '5:30pm' gives a daynight value of unknown.

Thanks.

@benhmoore
Copy link
Owner

Hi, @g1derekl. That's odd. Thanks for the heads up! I'm working on this project in my free time; as soon as I have the time, I will look into it and see what I can do!

  • Ben

@benhmoore benhmoore reopened this May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants