Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format YAML files with Prettier #698

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Format YAML files with Prettier #698

merged 1 commit into from
Oct 15, 2024

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Oct 15, 2024 •
edited
Loading

I was having a hard time reading the Python version changes in #696 more generally, reading the YAML files). If you're interested, here's a format setup with Prettier. I added a pre-commit hook to match the existing lint setup.

@zanieb zanieb changed the title Format YAML files with prettier Format YAML files with Prettier Oct 15, 2024
@zanieb zanieb marked this pull request as ready for review October 15, 2024 02:06
benfred
benfred approved these changes Oct 15, 2024
View reviewed changes
Copy link
Owner

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ! Thanks for also adding the pre-commit hook so this stays formatted

@benfred benfred merged commit f01b43a into benfred:master Oct 15, 2024
70 checks passed
@benfred benfred added the ci label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfred benfred benfred approved these changes

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanieb @benfred