Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug introduced by commit 5820bf6a7ef56718284add709bc56cc7b8cb6c16 #688

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

jiangliu
Copy link
Contributor

Commit 5820bf6 removes field addr and size from BinaryInfo, which are used when feature unwind is enabled. So recover these two fields.

Fix building error:
cargo build --all-features
error[E0609]: no field addr on type &BinaryInfo
--> src/binary_parser.rs:18:22
|
18 | addr >= self.addr && addr < (self.addr + self.size)
| ^^^^ unknown field
|
= note: available fields are: symbols, bss_addr, bss_size

error[E0609]: no field addr on type &BinaryInfo
--> src/binary_parser.rs:18:43
|
18 | addr >= self.addr && addr < (self.addr + self.size)
| ^^^^ unknown field
|
= note: available fields are: symbols, bss_addr, bss_size

error[E0609]: no field size on type &BinaryInfo
--> src/binary_parser.rs:18:55
|
18 | addr >= self.addr && addr < (self.addr + self.size)
| ^^^^ unknown field
|
= note: available fields are: symbols, bss_addr, bss_size

Commit 5820bf6 removes field `addr` and
`size` from BinaryInfo, which are used when feature `unwind` is enabled.
So recover these two fields.

Fix building error:
cargo build --all-features
error[E0609]: no field `addr` on type `&BinaryInfo`
  --> src/binary_parser.rs:18:22
   |
18 |         addr >= self.addr && addr < (self.addr + self.size)
   |                      ^^^^ unknown field
   |
   = note: available fields are: `symbols`, `bss_addr`, `bss_size`

error[E0609]: no field `addr` on type `&BinaryInfo`
  --> src/binary_parser.rs:18:43
   |
18 |         addr >= self.addr && addr < (self.addr + self.size)
   |                                           ^^^^ unknown field
   |
   = note: available fields are: `symbols`, `bss_addr`, `bss_size`

error[E0609]: no field `size` on type `&BinaryInfo`
  --> src/binary_parser.rs:18:55
   |
18 |         addr >= self.addr && addr < (self.addr + self.size)
   |                                                       ^^^^ unknown field
   |
   = note: available fields are: `symbols`, `bss_addr`, `bss_size`

Signed-off-by: Jiang Liu <[email protected]>
Copy link
Owner

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

I was trying to figure out how this bug got past CI - since we should be building wheels on linux/windows with unwind support for native profiling.

It seems like the native profiling feature has been disabled in the wheels produced by the CI runs with - and trying to use the native profiling feature from the wheels produced by CI will show:

$ py-spy record --native
error: Found argument '--native' which wasn't expected, or isn't valid in this context

	If you tried to supply `--native` as a value rather than a flag, use `-- --native`

=(.

Anyways, I have a fix for the CI in here #691 -

thanks again for pointing this out

@benfred benfred merged commit c9e422b into benfred:master Oct 11, 2024
69 checks passed
@benfred benfred added the bug Something isn't working label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants