Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows build and lint #685

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Fix Windows build and lint #685

merged 5 commits into from
Oct 10, 2024

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Oct 10, 2024

@benfred regarding #679 (comment)

Includes a few other changes as we debugged the cause of the failure.

This looks like an undeclared dependency in `remoteproess`?
@zanieb zanieb changed the title Fix Windows lints Fix Windows build and lint Oct 10, 2024
Copy link
Owner

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The changes look good to me,

@benfred
Copy link
Owner

benfred commented Oct 10, 2024

I'd like to get the windows CI working before merging - I realized I might have messed up the how python is installed in the last PR (moved setup-python to the wrong location in the GHA yaml), and am also testing out a tweak to fix in this other PR
#642

`console` requires an older version of `windows-sys` still
@zanieb
Copy link
Contributor Author

zanieb commented Oct 10, 2024

Yeah agree. I'm pulling updates from my fork to see if one of those fixes the issue — I don't know what else I would have changed to make CI pass.

@zanieb
Copy link
Contributor Author

zanieb commented Oct 10, 2024

It looks like you might have changed from Python 3.9 -> 3.11?

@benfred
Copy link
Owner

benfred commented Oct 10, 2024

I'm sorta wondering if this is related to the python version being tested - I'm getting a different error with python 3.10 than with python 3.11 in CI, and I'm wondering if the working versions are with python 3.9.

Because of how I messed up the setup python install, its possible that the 'fix clippy' pr we merged tested with python 3.9 (since the install for python 3.11 happened afterwards).

@benfred
Copy link
Owner

benfred commented Oct 10, 2024

It looks like you might have changed from Python 3.9 -> 3.11?

yeah, I'm testing now on #642 with 3.9 to see.

The error with 3.10 was called Result::unwrap()on anErrvalue: Failed to find a python interpreter in the .data section https://github.com/benfred/py-spy/actions/runs/11279360838/job/31369936001?pr=642 - which might be the same as #684 (so potentially a real issue with python 3.10 on windows, rather than a false positive in CI)

@zanieb
Copy link
Contributor Author

zanieb commented Oct 10, 2024

Yeah 1d0ffc1 resolves the error.

If you want, I can separate that commit from this pull request. Otherwise, it seems fine to merge this as a whole.

@benfred
Copy link
Owner

benfred commented Oct 10, 2024

I'm good merging this as a whole - thanks for fixing.

It does like there is an issue on windows with python 3.10+ that needs fixing =( - but that doesn't need to be fixed in this PR.

@benfred benfred merged commit 8e80803 into benfred:master Oct 10, 2024
185 checks passed
@benfred benfred added the ci label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants