Add support for writing out Speedscope files #134
Merged
+598
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for writing out speedscope files, as well as writing out raw call stack data. The speedscope code is adapted from rbspy. This change also refactors the commandline arguments significantly, changing to take subcommands (```py-spy dump -p 1234```) instead of flags. While this is a breaking change, I think it is a better long term solution for py-spy - and it makes more sense for the '-f' flag to be the file format and '-o' to be the filename (which would have broken commandline compatability anyways).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for writing out speedscope files, as well as writing out raw
call stack data. The speedscope code is adapted from rbspy.
This change also refactors the commandline arguments significantly, changing
to take subcommands (
py-spy dump -p 1234) instead of flags. While thisis a breaking change, I think it is a better long term solution for py-spy -
and it makes more sense for the '-f' flag to be the file format and '-o'
to be the filename (which would have broken commandline compatability anyways).