Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flame graphs without Perl #38

Closed
kud1ing opened this issue Sep 15, 2018 · 7 comments
Closed

Flame graphs without Perl #38

kud1ing opened this issue Sep 15, 2018 · 7 comments
Labels
enhancement New feature or request

Comments

@kud1ing
Copy link

kud1ing commented Sep 15, 2018

Options to create flame graphs in Rust:

Other options:

See also #7

@TyOverby
Copy link

TyOverby commented Sep 16, 2018

@kud1ing I've actually been working on a new project for flamegraph visualization here
https://github.com/TyOverby/fireplace

Example of a simple flame graph being visualized:
image

After working on it for quite some time, I found https://www.speedscope.app/ and it's better in almost every way. I'm going to work on getting bincode to export to something that speedscope can read.

@benfred benfred added the enhancement New feature or request label Sep 18, 2018
@yajo
Copy link

yajo commented Nov 30, 2018

I also love speedscope. This issue should be relabeled "support speedscope format" or similar.

@aparamon
Copy link

aparamon commented Dec 18, 2018

It appears that https://www.speedscope.app supports performance logs as output by e.g. https://github.com/evanhempel/python-flamegraph (and compatible with https://github.com/brendangregg/FlameGraph).

Adding option to dump raw performance logs will provide a #45 and is a very low-hanging fruit.

@jlfwong
Copy link

jlfwong commented Jan 28, 2019

Hi! speedscope author here. FWIW, while the stack collapse format output accepted by brendangregg/FlameGraph does indeed import successfully into speedscope, you'll get a higher quality import complete with filenames and line numbers if you target speedscope's own file format.

More information here: https://github.com/jlfwong/speedscope/wiki/Importing-from-custom-sources#speedscopes-file-format

I contributed support to rbspy to output to this format: rbspy/rbspy#161

Once some way of importing into speedscope from py-spy exists, regardless of what it is, please let me know and I'll update speedscope's own documentation to list it as supported 😄

@pquentin
Copy link

I would also be happy to be able to use py-spy without having to first install perl in my Docker containers.

benfred added a commit that referenced this issue May 18, 2019
Use inferno to generate flamegraphs instead of vendoring the perl package.
This removes the requirement to have perl installed.
(#38)
This was referenced May 18, 2019
@benfred
Copy link
Owner

benfred commented May 18, 2019

That latest PR removes the need for perl: #114.

I also totally agree that getting speedscope support in here is worth doing. I've created a new issue to track #115 - thumb it up if you think I should prioritize

@benfred
Copy link
Owner

benfred commented May 19, 2019

fix is in v0.1.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants