Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedscope format doesn't seem to respect -F #201

Closed
tavianator opened this issue Nov 28, 2019 · 2 comments
Closed

Speedscope format doesn't seem to respect -F #201

tavianator opened this issue Nov 28, 2019 · 2 comments

Comments

@tavianator
Copy link

When using py-spy record -f speedscope, the -F flag seems to make no difference. Functions are still split into separate chunks by line number. Additionally the line number isn't even visible in the sandwich view, which makes it a bit hard to use.

benfred added a commit that referenced this issue Dec 8, 2019
Previously all speedscope output included the line number, even if the user
generated the profile with the -F flag (Aggregate samples by function name
instead of by line number). Fix to not include line numbers in speedscope
profiles with the -F flag (#201)
@benfred
Copy link
Owner

benfred commented Dec 8, 2019

Thanks for the bug report! #202 changes to not include line numbers in speedscope profiles when the -F flag is used.

The line number not being visible in sandwich view issue is being tracked jlfwong/speedscope#247 right now

@benfred
Copy link
Owner

benfred commented Dec 9, 2019

Fix is in 0.3.1

@benfred benfred closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants