Python 3.13 Support

benfred · Oct 19, 2024 · e7b96d6 · e7b96d6
1 parent 264dbd7
commit e7b96d6
Show file tree

Hide file tree

Showing 9 changed files with 13,897 additions and 37 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -203,15 +203,6 @@ jobs:
             3.10.0,
             3.10.15,
             3.11.0,
-            3.11.1,
-            3.11.2,
-            3.11.3,
-            3.11.4,
-            3.11.5,
-            3.11.6,
-            3.11.7,
-            3.11.8,
-            3.11.9,
             3.11.10,
             3.12.0,
             3.12.1,
@@ -221,31 +212,14 @@ jobs:
             3.12.5,
             3.12.6,
             3.12.7,
+            3.13.0,
           ]
         # TODO: also test windows
         os: [ubuntu-20.04, macos-13]
         # some versions of python can't be tested on GHA with osx because of SIP:
         exclude:
           - os: macos-13
             python-version: 3.11.0
-          - os: macos-13
-            python-version: 3.11.1
-          - os: macos-13
-            python-version: 3.11.2
-          - os: macos-13
-            python-version: 3.11.3
-          - os: macos-13
-            python-version: 3.11.4
-          - os: macos-13
-            python-version: 3.11.5
-          - os: macos-13
-            python-version: 3.11.6
-          - os: macos-13
-            python-version: 3.11.7
-          - os: macos-13
-            python-version: 3.11.8
-          - os: macos-13
-            python-version: 3.11.9
           - os: macos-13
             python-version: 3.11.10
           - os: macos-13

diff --git a/ci/update_python_test_versions.py b/ci/update_python_test_versions.py
@@ -38,10 +38,10 @@ def get_github_python_versions():
 
         # for older versions of python, don't test all patches
         # (just test first and last) to keep the test matrix down
-        if major == 2 or minor <= 10:
+        if major == 2 or minor <= 11:
             patches = [patches[0], patches[-1]]
 
-        if major == 3 and minor >= 13:
+        if major == 3 and minor > 13:
             continue
 
         versions.extend(f"{major}.{minor}.{patch}" for patch in patches)
@@ -82,7 +82,7 @@ def update_python_test_versions():
     # since it currently fails in GHA on SIP errors
     exclusions = []
     for v in versions:
-        if v.startswith("3.11") or v.startswith("3.12"):
+        if v.startswith("3.11") or v.startswith("3.12") or v.startswith("3.13"):
             exclusions.append("          - os: macos-13\n")
             exclusions.append(f"            python-version: {v}\n")
     first_exclude_line = lines.index("        exclude:\n", first_line)

diff --git a/src/python_bindings/mod.rs b/src/python_bindings/mod.rs
@@ -2,6 +2,7 @@ pub mod v2_7_15;
 pub mod v3_10_0;
 pub mod v3_11_0;
 pub mod v3_12_0;
+pub mod v3_13_0;
 pub mod v3_3_7;
 pub mod v3_5_5;
 pub mod v3_6_6;
@@ -75,6 +76,13 @@ pub mod pyruntime {
                 minor: 11..=12,
                 ..
             } => 40,
+            // TODO: we can get this from the _PyRuntime.debug_offsets.runtime_state.interpreters_head
+            // way easier than we can get by updating manually, we should take advantagbe of that
+            Version {
+                major: 3,
+                minor: 13,
+                ..
+            } => 632,
             _ => 24,
         }
     }