Skip to content

Commit

Permalink
#431 Handle offsetted Elf segment case + FreeBSD CI
Browse files Browse the repository at this point in the history
An Elf segment may have a non-zero offset and that may result in
subtraction overflow when we calculating the symbol addresses.

Apart from that, CI workflows are run within GH Actions with FreeBSD
being notable exception. While FreeBSD is not supported on actions,
the conventional workaround is to run builds on macos runner using a
vagrant box.

This change
- Handles the subtraction overflow case by defaulting to zero.
- removes cirrus config and sets up a FreeBSD GH action job.
- Also bumps proc-maps version in attempt to resolve #431
  • Loading branch information
akhramov committed Aug 11, 2021
1 parent 98795f0 commit 25b4fda
Show file tree
Hide file tree
Showing 7 changed files with 209 additions and 62 deletions.
20 changes: 0 additions & 20 deletions .cirrus.yml

This file was deleted.

25 changes: 25 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,31 @@ env:
CARGO_TERM_COLOR: always

jobs:
build-freebsd-amd64:
runs-on: macos-latest

strategy:
matrix:
box:
- fbsd_13_0
- fbsd_12_2

steps:
- name: Cache vagrant boxes
id: cache-vagrant-boxes
uses: actions/cache@v2
with:
path: ~/.vagrant.d/
key: ${{ matrix.box }}-vm-cache
- uses: actions/checkout@v2
- name: Set up vagrant
run: vagrant up ${{ matrix.box }}
- name: Build
run: vagrant ssh ${{ matrix.box }} -- "cd /vagrant; cargo build --verbose"
- name: Test
run: vagrant ssh ${{ matrix.box }} -- "cd /vagrant; cargo test"


build-linux-armv7:
runs-on: [self-hosted, linux, arm]
steps:
Expand Down
184 changes: 144 additions & 40 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 25b4fda

Please sign in to comment.