Release GIL on GPU calls #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code was holding on the GIL when training models on the GPU or when calculating results. This caused some jank on progress bars displaying in jupyter notebooks, as well as just being poor form. Fix by releasing the GIL before starting on gpu code that will take an appreciable amount of time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code was holding on the GIL when training models on the GPU
or when calculating results. This caused some jank on progress bars
displaying in jupyter notebooks, as well as just being poor form.
Fix by releasing the GIL before starting on gpu code that will take
an appreciable amount of time.