Fix ALS model for case of > 2^31 interactions #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ALS model was spinning for ever when trying to train with more than 2^31 interactions. This was caused by using 32 bit ints in the cython code which overflowed. Fix.
|
@benfred Could you tag another release into pip/conda that includes this PR? It's been almost a year since the last one. Thanks! |
|
@GabrielBianconi There is a new release in pip/conda now (v0.4.8) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ALS model was spinning for ever when trying to train with more than
2^31 interactions. This was caused by using 32 bit ints in the cython
code which overflowed. Fix.