WIP migration to CI4 #1273
WIP migration to CI4 #1273
Conversation
Controllers/Auth.php
Outdated
| /** | ||
| * @return array A CSRF key-value pair | ||
| */ | ||
| public function _get_csrf_nonce(): array |
There was a problem hiding this comment.
I think this can be refactored away now that CI offerers CSRF built in
There was a problem hiding this comment.
You 'are right.
We can remove CSRF in the branch '3' to.
Config/IonAuth.php
Outdated
| | For more information, check the password_hash function help: http://php.net/manual/en/function.password-hash.php | ||
| | | ||
| */ | ||
| public $hash_method = 'bcrypt'; // bcrypt or argon2 |
There was a problem hiding this comment.
Need to this the spacing here down to like 126
|
Looking really good. Lmk when you're ready and I'll set aside some time to do some manual testing and poking around. |
I think there is still a bug in CodeIgniter
|
Hi, You can look the advancement : https://github.com/bvrignaud/CodeIgniter-Ion-Auth/tree/4 |
There was a problem hiding this comment.
This is looking great. Left a couple comments. Looking through this, it wouldn't be difficult to make this a generic PHP project from this point.
If you're up for that, I think the main effort is injecting all the dependencies. Those dependencies can still be CI4 libraries. If you arent up for that, no worries, this will work for CI4 and we could cut a new version thats generic.
I like it to, but I think there is still a bug in CodeIgniter 4 develop with loading config file. I Had created a new issue : codeigniter4/CodeIgniter4#1293 I like the idea to have the generic config file in module/config directory and if we want to personalize it, we can override it in the application/config directory. |
fixed ukrainian translation
|
Merging whats here so far |
|
@bvrignaud what is the status here? need help with unit testing or anything else? |
|
Good news. It's usable, I use it on a new project. But I think there are still many things to do. Go on guys, try it and improve it ! |
|
Awesome, I'll get the word out. |
|
Excellent. Will try it out. |
This is a migration to CI4 (#1270).
It's works but there are still things to do.
Maybe rename functions an d variables in camelCase to be compatible with CI 4 coding standard.
TODO :
[] make unit test
[] make installation with composer