Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

Remove pycrypto and iGrill Keys From the Code #7

Closed
kins-dev opened this issue Apr 10, 2019 · 5 comments
Closed

Remove pycrypto and iGrill Keys From the Code #7

kins-dev opened this issue Apr 10, 2019 · 5 comments

Comments

@kins-dev
Copy link

I put together a short blog post here https://blog.kins.dev/2019/04/igrill-device-support-for-igrill-smoker.html

Basically, the way handshaking is done, if you present a challenge of all zeros, you can simplify the authentication to:

  • Present the challenge
  • Read the response
  • Present the response

You can find tested code in my own project https://git.kins.dev/igrill-smoker

The reason you may want to do this is, pycrypto has a couple of security issues:

@niXta1
Copy link

niXta1 commented Apr 21, 2019

I put together a short blog post here https://blog.kins.dev/2019/04/igrill-device-support-for-igrill-smoker.html ...

@kins-dev any chance for a fork of this project with some fixes?
I think bendikwa is out...

@kins-dev
Copy link
Author

@niXta1 I could fork it. I separated my first fork into a project because I basically built a whole product.

@bendikwa
Copy link
Owner

Hi.
As you might have guessed, I do not have a lot of time to code on this for the moment, but when I do, I spend it on making it python3 compatible.

I am very thankful for the suggestion, and have implemented it on the experimental python3 branch, which i hope to get merged to master not too long into the future.

-Bendik

@bendikwa bendikwa reopened this May 18, 2019
@kins-dev
Copy link
Author

If you need help with migration to Python 3, I've already done that on my master branch

@bendikwa
Copy link
Owner

This is now merged to master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants