-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task semantics behaviour #276
Open
zuzuleinen
wants to merge
16
commits into
main
Choose a base branch
from
task-semantics-behaviour
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Equanox
reviewed
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implemented all scenarios from #229 under Behavior based on those changes section.
More specific:
input
is mandatory on build tasks except when task hasrebuild:always
or is a compound task(has only dependsOn node on it)target
andrebuild: always
are not allowed on the same task. They are incompatible now.StateNoRebuildRequired
which is similarStateCached
. The differennce is that the reason forStateCached
is because the targed was fetched from cache while the reason forStateNoRebuildRequired
was that a rebuild was not necessary but there was no target to fetch from cache.Tests for functionality are added in test/e2e/tasksemantics. The are all green, however there are still tests that needs fixing.