Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #435
I tried to split individual commits to help with the review.
Note regarding b33b5cf
I noticed that
Benchee.UnknownProfilerError
might have accidentally been declared asBenchee.Profile.Benchee.UnknownProfilerError
, hence the proposed move to a new file where we can define custom errors in the top-levelBenchee
. If nesting was voluntary here, I'm happy to replicate this pattern and define it withinBenchee.Benchmark.Runner
.Note regarding the name
I'm OK with the originally proposed
:assert_all_same
as well, but since it is used withinpre_check
, the notion of checking/asserting felt slightly redundant andpre_check: :all_same
felt enough. Happy to change it back or to something else entirely 🙂Note regarding 44dff6f
I implemented a custom collector in order to retrieve the return value, but thanks to dialyzer I realized it didn't strictly speaking match the behaviour which expects a number. We could perhaps override
scenario.function
to a wrapper sending a message to the parent, but I wanted to consult you first about the best approach.