-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use textual 'null' for dependencies without group (#725) #731
Conversation
Thanks! Can you fix the test failures? It might just be some minor updates, e.g. DependencyUpdatesSpec > Single project with flatDir repository FAILED
Condition not satisfied:
unresolved.collect { it.selector }.collectEntries { dependency -> [['group': dependency.group, 'name': dependency.name]: dependency.version] } == [['group': 'null', 'name': 'guava-18.0']: NONE_VERSION]
| | | | |
| [:guava-18.0:none] [[group:, name:guava-18.0]:none] false none
[:guava-18.0:none]
at com.github.benmanes.gradle.versions.DependencyUpdatesSpec.Single project with flatDir repository_closure21(DependencyUpdatesSpec.groovy:359)
at groovy.lang.Closure.call(Closure.java:412)
at spock.lang.Specification.with(Specification.java:191)
at com.github.benmanes.gradle.versions.DependencyUpdatesSpec.Single project with flatDir repository(DependencyUpdatesSpec.groovy:358) |
Hm, I'm not sure about the undeclared failure, whether my changes just surfaced that there is some other bug in |
Can you maybe have a look? |
Actually if I comment out the |
I pushed a version with that change, let's see whether something else breaks or you say this actually is necessary. :-) |
Well, the tests passed with that change :-D |
It looks good to me. Running it against Caffeine and I don't see any of the hidden dependencies in the report (bundled ant, jacoco) and the undeclared category from v39 has unit tests. |
Fixes #725