Only resolve resolvable configurations #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #718 Updates plugin to only resolve resolvable configurations. As a result, configurations like implementation are not resolved individually, but transitively via any resolvable configurations which extend it. To handle this change, Resolver.kt was updated throughout to use allDependencies and allDependencyConstraints in order to ensure the resolved/unresolved dependency comparisons with the latest versions include inherited dependencies from non-resolvable configurations which were previously being resolved individually.
|
Thanks! |
|
released, thanks @jvandort |
tresat
added a commit
to tresat/gradle-versions-plugin
that referenced
this pull request
Apr 17, 2023
This fixes a mistake in PR ben-manes#721 which used allDependencies here instead of dependencies, causing the inherited set always be empty, as a result of subtracting allDependencies from it. This also prevents inherited kotlin deps from being included in the latest set, to avoid issues with having the original and modifies dependencies both added to the copy.
ben-manes
pushed a commit
that referenced
this pull request
Apr 17, 2023
This fixes a mistake in PR #721 which used allDependencies here instead of dependencies, causing the inherited set always be empty, as a result of subtracting allDependencies from it. This also prevents inherited kotlin deps from being included in the latest set, to avoid issues with having the original and modifies dependencies both added to the copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #718
Updates plugin to only resolve resolvable configurations. As a result, configurations like implementation are not resolved individually, but transitively via any resolvable configurations which extend it. To handle this change, Resolver.kt was updated throughout to use allDependencies and allDependencyConstraints in order to ensure the resolved/unresolved dependency comparisons with the latest versions include inherited dependencies from non-resolvable configurations which were previously being resolved individually.