-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
html report #418
html report #418
Conversation
src/main/groovy/com/github/benmanes/gradle/versions/reporter/HtmlReporter.groovy
Show resolved
Hide resolved
src/main/groovy/com/github/benmanes/gradle/versions/updates/DependencyUpdatesReporter.groovy
Show resolved
Hide resolved
src/main/groovy/com/github/benmanes/gradle/versions/reporter/HtmlReporter.groovy
Show resolved
Hide resolved
src/main/groovy/com/github/benmanes/gradle/versions/reporter/HtmlReporter.groovy
Show resolved
Hide resolved
src/main/groovy/com/github/benmanes/gradle/versions/reporter/HtmlReporter.groovy
Show resolved
Hide resolved
src/main/groovy/com/github/benmanes/gradle/versions/reporter/HtmlReporter.groovy
Show resolved
Hide resolved
This looks pretty great, just some minor comments to consider. I sent you commit access to merge when you're ready. You can even release this yourself :)
|
src/main/groovy/com/github/benmanes/gradle/versions/reporter/HtmlReporter.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/com/github/benmanes/gradle/versions/reporter/HtmlReporter.groovy
Outdated
Show resolved
Hide resolved
Tried the new commit, pretty cool! :) I sent you an invite to have commit access. When you're happy, feel free to merge. |
crap. ok, need to know how Caffeine may use it. There is some logic in the second commit that chooses where to get the version and it differs from how the plain text report does it. I couldnt get the same syntax to work from there (eg. available[revision]) |
sorry, should have commented on the prior convo, moved it up there for resolution. |
src/main/groovy/com/github/benmanes/gradle/versions/reporter/HtmlReporter.groovy
Outdated
Show resolved
Hide resolved
supporting and tested with the three defined revision values - release, milestone, and integration. |
Verified on Caffeine, looks great! |
No description provided.