Latest version v0.43.0 doesn't produce html report

[gkurmaev]

After update yesterday our task, which is configured the following way:

tasks.named<DependencyUpdatesTask>("dependencyUpdates").configure {

  // Example 1: reject all non stable versions
  rejectVersionIf {
    isNonStable(candidate.version)
  }

  // optional parameters
  checkConstraints = true
  checkForGradleUpdate = true
  outputFormatter = "json, html"
  outputDir = "build/dependencyUpdates"
  reportfileName = "report"
}

is no longer generating json and html reports (but a json and txt instead), which we uploaded somewhere else as a part of CI-pipeline, thus breaking it.

[gkurmaev]

Removing the extra space after the comma actually fixed the issue, so

outputFormatter = "json,html"

[ben-manes]

Looks like a small typo in the groovy to kotlin migration. The groovy code used String's replaceAll which takes a regex, whereas the kotlin version uses replace which does not.

gradle-versions-plugin/src/main/groovy/com/github/benmanes/gradle/versions/updates/DependencyUpdatesReporter.groovy

Line 127 in b53e44f

String formatter = formatterOriginal.replaceAll("\\s", "")

gradle-versions-plugin/gradle-versions-plugin/src/main/kotlin/com/github/benmanes/gradle/versions/updates/DependencyUpdatesReporter.kt

Line 112 in cc714f8

return when (formatterOriginal.replace("\\s", "")) {

[ben-manes]

hmm.. seems that kotlin's replace is the same as Java's replaceAll, so I'm not sure why it wouldn't take.

[ben-manes]

Oh, they have multiple variants overloaded with the same name and different behavior. Very confusing stdlib, but I think we can use a trim() here. Seems kotlin has many footguns, like their infamous non-atomic operations on atomics...

It should have been formatterOriginal.replace(Regex("\\s"), ""), but did a string replacement instead.

[gkurmaev]

Oh wow, that was rather unexpected of you to actually fix a closed issue, thanks!