Breaking change in 0.23.0? #331

stumacsolutions · 2019-08-30T09:30:08Z

I've just picked up the new version of your library and we now get the following error when running useLatestVersions:

Could not set unknown property 'resolutionStrategy' for task ':dependencyUpdates' of type com.github.benmanes.gradle.versions.updates.DependencyUpdatesTask.

If we change our gradle config from dependencyUpdates.resolutionStrategy to
dependencyUpdates.resolutionStrategyAction things work as before.

Just wondering if this was an intentional change or not before we roll this fix out across our projects?

The text was updated successfully, but these errors were encountered:

augi · 2019-08-30T11:48:39Z

I have the same problem (tested with Gradle 5.6 and 5.6.1):
Could not set unknown property 'resolutionStrategy' for task ':client:dependencyUpdates' of type com.github.benmanes.gradle.versions.updates.DependencyUpdatesTask.

johnjohndoe · 2019-08-30T14:40:38Z

The version itself runs for me. However, if I apply the latest resolutionStrategy snippet from the README.md there is no version being output.

"Old" resolution strategy

dependencyUpdates.resolutionStrategy {
    componentSelection { rules ->
        rules.all { ComponentSelection selection ->
            boolean rejected = ["alpha", "beta", "rc", "cr", "m", "preview", "b", "ea"].any { qualifier ->
                selection.candidate.version ==~ /(?i).*[.-]$qualifier[.\d-+]*/
            }
            if (rejected) {
                selection.reject("Release candidate")
            }
        }
    }
}

Output

> Task :dependencyUpdates
Failed to resolve :app:debugAndroidTestCompileClasspath
Failed to resolve :app:debugCompileClasspath
Failed to resolve :app:debugUnitTestCompileClasspath
Failed to resolve :app:releaseCompileClasspath
Failed to resolve :app:releaseUnitTestCompileClasspath
Failed to resolve :roadsigns:debugAndroidTestCompileClasspath
Failed to resolve :roadsigns:debugCompileClasspath
Failed to resolve :roadsigns:debugUnitTestCompileClasspath
Failed to resolve :roadsigns:releaseCompileClasspath
Failed to resolve :roadsigns:releaseUnitTestCompileClasspath

------------------------------------------------------------
: Project Dependency Updates (report to plain text file)
------------------------------------------------------------

The following dependencies are using the latest milestone version:
 - com.android.support.constraint:constraint-layout:1.1.3
 - com.android.support.test:rules:1.0.2
 - com.android.support.test.espresso:espresso-core:3.0.2
 - com.android.tools.build:aapt2:3.5.0-5435860
 - com.android.tools.build:gradle:3.5.0
 - com.android.tools.lint:lint-gradle:26.5.0
 - com.github.ben-manes:gradle-versions-plugin:0.23.0
 - com.jfrog.bintray.gradle:gradle-bintray-plugin:1.8.4
 - digital.wup:android-maven-publish:3.6.2
 - org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.50
 - org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.3.50

The following dependencies have later milestone versions:
 - com.android.support:appcompat-v7 [27.1.1 -> 28.0.0]
     http://developer.android.com/tools/extras/support-library.html
 - com.android.support:support-annotations [27.1.1 -> 28.0.0]
     http://developer.android.com/tools/extras/support-library.html
 - com.android.support:support-vector-drawable [27.1.1 -> 28.0.0]
     http://developer.android.com/tools/extras/support-library.html

Gradle current updates:
 - Gradle: [5.6.1: UP-TO-DATE]

"New" resolution strategy

dependencyUpdates.resolutionStrategy {
    componentSelection { rules ->
        rules.all {
            def isNonStable = { String version ->
                ["alpha", "beta", "rc", "cr", "m", "preview", "b", "ea"].any { qualifier ->
                    version ==~ /(?i).*[.-]\$qualifier[.\\d-+]*/
                }
            }
            if (isNonStable(candidate.version) && !isNonStable(currentVersion)) {
                selection.reject("Release candidate")
            }
        }
    }
}

Output

> Task :dependencyUpdates
Failed to resolve :app:debugAndroidTestCompileClasspath
Failed to resolve :app:debugCompileClasspath
Failed to resolve :app:debugUnitTestCompileClasspath
Failed to resolve :app:releaseCompileClasspath
Failed to resolve :app:releaseUnitTestCompileClasspath
Failed to resolve :roadsigns:debugAndroidTestCompileClasspath
Failed to resolve :roadsigns:debugCompileClasspath
Failed to resolve :roadsigns:debugUnitTestCompileClasspath
Failed to resolve :roadsigns:releaseCompileClasspath
Failed to resolve :roadsigns:releaseUnitTestCompileClasspath

------------------------------------------------------------
: Project Dependency Updates (report to plain text file)
------------------------------------------------------------

Failed to determine the latest version for the following dependencies (use --info for details):
 - com.android.support:appcompat-v7
 - com.android.support:support-annotations
 - com.android.support:support-vector-drawable
 - com.android.support.constraint:constraint-layout
 - com.android.support.test:rules
 - com.android.support.test.espresso:espresso-core
 - com.android.tools.build:aapt2
 - com.android.tools.build:gradle
 - com.android.tools.lint:lint-gradle
 - com.github.ben-manes:gradle-versions-plugin
 - com.jfrog.bintray.gradle:gradle-bintray-plugin
 - digital.wup:android-maven-publish
 - org.jetbrains.kotlin:kotlin-gradle-plugin
 - org.jetbrains.kotlin:kotlin-stdlib-jdk8

Gradle current updates:
 - Gradle: [5.6.1: UP-TO-DATE]

ben-manes · 2019-08-30T15:11:09Z

Sorry, this was unintentional. I’ll have a fix out by the end of the weekend.

cc @ghus-raba

ferinagy · 2019-08-30T19:25:04Z

Sample from readme:

dependencyUpdates.resolutionStrategy {
    componentSelection { rules ->
        rules.all {
            def isNonStable = { String version ->
                ["alpha", "beta", "rc", "cr", "m", "preview", "b", "ea"].any { qualifier ->
                    version ==~ /(?i).*[.-]\$qualifier[.\\d-+]*/
                }
            }
            if (isNonStable(candidate.version) && !isNonStable(currentVersion)) {
                selection.reject("Release candidate")
            }
        }
    }
}

Sorry, there is extra escape in the readme. It was fixed in #332. There should be version ==~ /(?i).*[.-]$qualifier[.\d-+]*/

Could not set unknown property

I have the same problem (tested with Gradle 5.6 and 5.6.1):
Could not set unknown property 'resolutionStrategy' for task ':client:dependencyUpdates' of type com.github.benmanes.gradle.versions.updates.DependencyUpdatesTask.

Can you post your resolutionStrategy, or some reproducible code? It seems you are accessing a property of the task

gradle-versions-plugin/src/main/groovy/com/github/benmanes/gradle/versions/updates/DependencyUpdatesTask.groovy

Line 56 in e3f310e

Action<? super ResolutionStrategyWithCurrent> resolutionStrategyAction = null

instead of a method

gradle-versions-plugin/src/main/groovy/com/github/benmanes/gradle/versions/updates/DependencyUpdatesTask.groovy

Line 79 in e3f310e

    
           void resolutionStrategy(final Action<? super ResolutionStrategyWithCurrent> resolutionStrategy) {

ben-manes · 2019-08-30T19:35:45Z

@ghus-raba I accidentally exposed the property instead of using the method, not being super great at Groovy and doing things ad hoc over weekends. In 894fbdf, I showed documentation which used = instead of a method. So unfortunately we should keep that working for backwards compatibility.

dependencyUpdates.resolutionStrategy = {
  componentSelection { rules ->
    rules.all { ComponentSelection selection ->
      boolean rejected = ['alpha', 'beta', 'rc', 'cr', 'm'].any { qualifier ->
        selection.candidate.version ==~ /(?i).*[.-]${qualifier}[.\d-]*/
      }
      if (rejected) {
        selection.reject('Release candidate')
      }
    }
  }
}

ferinagy · 2019-08-30T19:50:51Z

Ok, then renaming the property back to be same as method should do the trick. I think I changed it because of a codenarc warning. Although it changed from Closure to Action, so it might not work out of the box. Then if we want to keep it working, we would have to revert back to Closure and handle it in Resolver a bit differently.

ben-manes · 2019-08-30T20:03:55Z

I think the change from Closure to Action is compatible enough if the types are inferred by the build scripts. If the 99% case works and one plugin integration has to revise, then I think it's a fine break. If it leaks into the general case then a little adapter code can probably be done at the task prior to the Resolver (e.g. adapt from the Closure to Action before going downstream).

johnjohndoe · 2019-08-31T09:16:08Z

If you still need a project to try out the behavior you are invited to use mine.

ben-manes · 2019-09-01T03:16:03Z

Released version 0.24.

The direct assignment of the dependencyUpdates.resolutionStrategy property is supported again, but will issue a deprecation warning. Instead of an explicit =, prefer the DSL style of an assignment method.

// old style
dependencyUpdates.resolutionStrategy = { ... }
// proper style
dependencyUpdates.resolutionStrategy { ... }

This deprecated usage will show up as a build warning like other Gradle feature deprecations, where a detailed message is shown when running with --warning-mode=all.

johnjohndoe · 2019-09-01T11:11:39Z

Do you know why the dependencyUpdates task outputs the following?

Failed to resolve :app:debugAndroidTestCompileClasspath
...

johnjohndoe · 2019-09-01T11:17:10Z

I tested version 0.24 with the latest resolutionStrategy. It outputs this:

The following dependencies exceed the version found at the milestone revision level:
 - com.android.tools.build:gradle [3.5.0 <- 2.3.0]

while 0.24 with the former resolutionStrategy correctly outputs:

The following dependencies are using the latest milestone version:
 - com.android.tools.build:gradle:3.5.0

You can try out the behavior on this temporary branch.

ben-manes · 2019-09-01T11:40:18Z

I think that is because selection is not defined as the input argument, causing the reject(...) method to fail or not take effect. If you add ComponentSelection selection -> does that seem correct?

dependencyUpdates.resolutionStrategy {
  componentSelection { rules ->
    rules.all { ComponentSelection selection ->
      def isNonStable = { String version -> 
        ['alpha', 'beta', 'rc', 'cr', 'm', 'preview', 'b', 'ea'].any { qualifier ->
          version ==~ /(?i).*[.-]$qualifier[.\d-+]*/
        }
      }

      if (isNonStable(candidate.version) && !isNonStable(currentVersion)) {
        selection.reject('Release candidate')
      }
    }
  }
}

ben-manes · 2019-09-01T11:45:10Z

In regards to the configuration resolution failures, that seems to be an Android / Gradle bug. See #326 - they don't the handle detached configurations, e.g. like ours created by Configuration.copy(). You would need to ask those teams to resolve their oversight.

johnjohndoe · 2019-09-01T13:24:03Z

If you add ComponentSelection selection -> does that seem correct?

Applying your snippet produces the expected output. 👍 Thanks for your quick response.
I updated my branch.

stumacsolutions · 2019-09-01T17:31:58Z

Massive thanks for the quick response and fix, and I will migrate away from the deprecated configuration straight away.

ferinagy · 2019-09-02T06:51:06Z

@johnjohndoe BTW both rules -> and ComponentSelection selection -> should not be necessary anymore, as the closures should have proper delegates set. So even this should be ok:

dependencyUpdates.resolutionStrategy {
  componentSelection {
    all {
      def isNonStable = { String version -> 
        ['alpha', 'beta', 'rc', 'cr', 'm', 'preview', 'b', 'ea'].any { qualifier ->
          version ==~ /(?i).*[.-]$qualifier[.\d-+]*/
        }
      }

      if (isNonStable(candidate.version) && !isNonStable(currentVersion)) {
        reject('Release candidate')
      }
    }
  }
}

johnjohndoe · 2019-09-03T18:02:46Z

@ghus-raba Thanks. Looks good to me. I updated my branch. Please update the README.

ben-manes mentioned this issue Aug 30, 2019

Simplified resolutionStrategy #325

Open

ben-manes added a commit that referenced this issue Aug 31, 2019

Backwards compatibility of direct closure assignment (fixes #331)

5c1221a

ben-manes added a commit that referenced this issue Sep 1, 2019

Backwards compatibility of direct closure assignment (fixes #331)

5720042

ben-manes closed this as completed in 246b1ad Sep 1, 2019

jimshowalter mentioned this issue Sep 3, 2019

Still getting "Could not resolve" for all dependencies #336

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Breaking change in 0.23.0? #331

Breaking change in 0.23.0? #331

stumacsolutions commented Aug 30, 2019

augi commented Aug 30, 2019

johnjohndoe commented Aug 30, 2019

ben-manes commented Aug 30, 2019

ferinagy commented Aug 30, 2019

ben-manes commented Aug 30, 2019 •

edited

Loading

ferinagy commented Aug 30, 2019

ben-manes commented Aug 30, 2019

johnjohndoe commented Aug 31, 2019

ben-manes commented Sep 1, 2019

johnjohndoe commented Sep 1, 2019 •

edited

Loading

johnjohndoe commented Sep 1, 2019 •

edited

Loading

ben-manes commented Sep 1, 2019

ben-manes commented Sep 1, 2019

johnjohndoe commented Sep 1, 2019

stumacsolutions commented Sep 1, 2019

ferinagy commented Sep 2, 2019

johnjohndoe commented Sep 3, 2019 •

edited

Loading

Breaking change in 0.23.0? #331

Breaking change in 0.23.0? #331

Comments

stumacsolutions commented Aug 30, 2019

augi commented Aug 30, 2019

johnjohndoe commented Aug 30, 2019

"Old" resolution strategy

Output

"New" resolution strategy

Output

ben-manes commented Aug 30, 2019

ferinagy commented Aug 30, 2019

ben-manes commented Aug 30, 2019 • edited Loading

ferinagy commented Aug 30, 2019

ben-manes commented Aug 30, 2019

johnjohndoe commented Aug 31, 2019

ben-manes commented Sep 1, 2019

johnjohndoe commented Sep 1, 2019 • edited Loading

johnjohndoe commented Sep 1, 2019 • edited Loading

ben-manes commented Sep 1, 2019

ben-manes commented Sep 1, 2019

johnjohndoe commented Sep 1, 2019

stumacsolutions commented Sep 1, 2019

ferinagy commented Sep 2, 2019

johnjohndoe commented Sep 3, 2019 • edited Loading

ben-manes commented Aug 30, 2019 •

edited

Loading

johnjohndoe commented Sep 1, 2019 •

edited

Loading

johnjohndoe commented Sep 1, 2019 •

edited

Loading

johnjohndoe commented Sep 3, 2019 •

edited

Loading