Skip to content

Commit

Permalink
fix last review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
John Rokicki committed Sep 4, 2020
1 parent 449a944 commit 0d9e4a2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
3 changes: 2 additions & 1 deletion examples/groovy/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ dependencies {
'com.google.code.gson:gson',
'dom4j:dom4j'
upToDate 'backport-util-concurrent:backport-util-concurrent:3.1',
'backport-util-concurrent:backport-util-concurrent-java12:3.1'
'backport-util-concurrent:backport-util-concurrent-java12:3.1',
'org.openjdk.jmh:jmh-parent:1.25.2'
exceedLatest 'com.google.guava:guava:99.0-SNAPSHOT',
'com.google.guava:guava-tests:99.0-SNAPSHOT'
upgradesFound 'com.google.guava:guava:15.0',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -200,10 +200,12 @@ class HtmlReporter extends AbstractReporter {
}

private def String getDisplayableVersion(DependencyOutdated item) {
if (getRevision().equalsIgnoreCase("release-candidate")) {
return item.getAvailable()
if (getRevision().equalsIgnoreCase("milestone")) {
return item.getAvailable().getMilestone()
} else if (getRevision().equalsIgnoreCase("release")) {
return item.getVersion()
} else if (getRevision().equalsIgnoreCase("integration")) {
return item.getAvailable().getIntegration()
}
return ""
}
Expand Down Expand Up @@ -308,12 +310,12 @@ class HtmlReporter extends AbstractReporter {
}

private def getMvnVersionString(String group, String name, String version) {
// https://mvnrepository.com/artifact/com.azure/azure-core-http-netty/1.5.4
// https://search.maven.org/artifact/com.azure/azure-core-http-netty/1.5.4
if (version == null) {
return "";
}
String versionUrl = String.format("https://mvnrepository.com/artifact/%s/%s/%s", group, name, version)
return String.format("<a target=\"_blank\" href=\"%s\">%s</a>", versionUrl, "Mvn")
String versionUrl = String.format("https://search.maven.org/artifact/%s/%s/%s/bundle", group, name, version)
return String.format("<a target=\"_blank\" href=\"%s\">%s</a>", versionUrl, "Sonatype")
}

private def getBintrayVersionString(String group, String name, String version) {
Expand Down

0 comments on commit 0d9e4a2

Please sign in to comment.