same fixes as yesterday #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made more fields final applied google formatter gave the tests more slack to also succeed consistently on Windows 10
ben-manes
reviewed
Nov 2, 2021
Comment on lines
+165
to
+166
| assert maxLoadSize > 0; | ||
| assert maxDelay > 0; |
There was a problem hiding this comment.
purely fun fyi, but assert lost favor in Java's core libs where it used to be popular. This is because it increased the bytecode size compared to a regular check, which increased the chance for a method to exceed the inlining cliff (35 bytes). The keyword used to be used liberally in j.u.c., if I recall correctly, when originally written to favor readability. It was stripped out a few releases later when maximizing for performance instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #7 (comment)
made more fields final
applied google formatter
gave the tests more slack to also succeed consistently on Windows 10