Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate top-level classes for Nodes and Factories #200

Merged
merged 1 commit into from
Nov 6, 2017

Conversation

jvassev
Copy link
Contributor

@jvassev jvassev commented Nov 6, 2017

If nested, every method/class/field descriptor carries
the enclosing's class name and a $ sign.
Also slightly shorter name using french words to avoid name
collisions.

If nested, every method/class/field descriptor carries
the enclosing's class name and a $ sign.
Also slightly shorter name using french words to avoid name
collisions.
@ben-manes
Copy link
Owner

A few minor concerns.

  • All the classes are public, so we should make it generate package scoped.
  • The suppress warnings no longer applies. Would adding the annotation everywhere add back the bloat?

@ben-manes ben-manes merged commit db43053 into ben-manes:master Nov 6, 2017
@ben-manes
Copy link
Owner

I changed the visibility and added the SuppressWarnings annotations. Since the retention policy is SOURCE it doesn't end up in the byte code.

Thanks again :)

@jvassev
Copy link
Contributor Author

jvassev commented Nov 6, 2017

Hey, np. I was about to do the same :)

From this point I think only using a minifier/obfuscator can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants