Async Load All result is ignored when its size matches the cache size

[jonathannaguin]

Hello,

When my application starts I want to fill the cache with items so I am running this:

var cache = Caffeine.newBuilder()
                             .refreshAfterWrite(Duration.ofMinutes(5))
                             .buildAsync(this);
cache.getAll(List.of("*")) .get();

Disclaimer: I can't use a empty list, otherwise the AsyncCacheLoader never gets invoked (see

caffeine/caffeine/src/main/java/com/github/benmanes/caffeine/cache/LocalAsyncCache.java

Lines 138 to 140 in 5e834f8

	if (proxies.isEmpty()) {
	return composeResult(futures);
	}

).

So my only option is to use a dummy key like "*", this works fine and my asyncLoadAll gets called and I can return a map of items.
The problem I have is when this method returns one single item as this piece of code assumes the entry returned is the same as the one used in the getAll invocation:

caffeine/caffeine/src/main/java/com/github/benmanes/caffeine/cache/LocalAsyncCache.java

Lines 278 to 280 in 5e834f8

	if (proxies.size() == result.size()) {
	return;
	}

[ben-manes]

Oh, that's a good catch. I agree that size comparison looks unnecessary and wrong. I was able to confirm your problem and fix in a unit test. My weekdays are hectic so more often I work on a release over the weekend, so hopefully I can get that to you by next Monday.

[jonathannaguin]

Thanks a lot @ben-manes !

[ben-manes]

Hi @jonathannaguin,

I apologize but it looks like I won't be ready to release this weekend. I have been assisting two other teams privately which require have minor API changes in the `Cache.policy() extensions (one is a persistent and the other is a distributed cache). Those discussions and iterations have split my free time for this project. I'll try to make their changes over this coming week and have something ready soon.

In the meantime if this is causing trouble then you might either (a) return an extra dummy unreachable entry to skip this guard or (b) use jitpack.io to temporarily depend on the fixed commit.

Thanks again for the bug report and your patience.

[jonathannaguin]

Hey @ben-manes, no problem, I am using a dummy value until this gets released.
Thanks a lot for your support.

[ben-manes]

Sorry for the long delay, this has been released.