Update modules in ExtensionHelper.php core extensions list to fix PHP notice after update #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
approved these changes
Aug 11, 2019
|
Thanks @richard67 for all of your PRs |
|
Welcome. Just wanted to help to fix db stuff. New template looks good by the way. |
bembelimen
pushed a commit
that referenced
this pull request
Dec 7, 2020
- Move the fonts abd their scss to `build/media_source/fonts` - Modify the the css build script so it copies the fonts and the compiled css to `media/fonts`. - Use a `filelist` field for selecting the fonts => No need to edit `templateDetails.xml` anymore for adding new fonts. - Dynamically register the asset so no need to edit `joomla.asset.json` anymore for adding new fonts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) for joomla#25570.
This fixes the PHP notice mentioned in the comment here:#37 (comment), I've just tested this.
The reason is that the extensions helper holds a table of core extensions for which no update check is made like it would be for 3rd party extensions. The new modules from the backend template were not in the list and so caused an update check which failed.