Add new error case for SCM parsing.

Will error if packet is too short. Adds slice upper bound for checksum.
bemasher · Oct 29, 2014 · ea81369 · ea81369
1 parent 2b055fc
commit ea81369
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/scm/scm.go b/scm/scm.go
@@ -62,7 +62,11 @@ func NewParser() (p Parser) {
 func (p Parser) Parse(data parse.Data) (msg parse.Message, err error) {
 	var scm SCM
 
-	if p.Checksum(data.Bytes[2:]) != 0 {
+	if l := len(data.Bytes); l < 12 {
+		err = fmt.Errorf("packet too short: %d", l)
+		return
+	}
+	if p.Checksum(data.Bytes[2:12]) != 0 {
 		err = errors.New("checksum failed")
 		return
 	}