Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up action #970

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Cleaning up action #970

merged 3 commits into from
Oct 10, 2023

Conversation

belav
Copy link
Owner

@belav belav commented Oct 5, 2023 •
edited
Loading

It looks like the newest setup-dotnet will read the global.json file, which appears to eliminate the need to specify the version at all

@belav belav changed the title this may read global.json Cleaning up action Oct 5, 2023
shocklateboy92
shocklateboy92 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@shocklateboy92 shocklateboy92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We might not need the github actions variable after all then.

@shocklateboy92 shocklateboy92 enabled auto-merge (squash) October 10, 2023 13:30
@shocklateboy92 shocklateboy92 merged commit dbc74ca into main Oct 10, 2023
3 checks passed
@shocklateboy92 shocklateboy92 deleted the better-action branch October 10, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shocklateboy92 shocklateboy92 shocklateboy92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@belav @shocklateboy92